This conference report discusses the outcomes of workshops carried out by the Advocacy Safeguards Agency (ASA) and the Scottish Independent Advocacy Alliance (SIAA) in association with the Scottish Executive. In preparation for revising guidance on advocacy provision, these workshops focused on good practice in advocacy which highlighted some of the issues advocates, advocacy organisations and others would like guidance on.